Small cloudbuster fixes #1279
Small cloudbuster fixes #1279
Conversation
NovemberTang
force-pushed
the
nt/prod-params
branch
from
12e0178
to
2f62f3f
Compare
| Remediation: [Documentation](https://example.com)`, | ||
| }); | ||
| }); | ||
| it('should return nothing if the first observed date is older than the cut-off', () => { |
There was a problem hiding this comment.
This might be a nice candidate for property-based testing. No need to do it here, but if you're interested to look at doing that together at any point we can drop fast-check into the project and try it out?
NovemberTang
force-pushed
the
nt/prod-params
branch
from
a21087f
to
d0fcdc9
Compare
NovemberTang
force-pushed
the
nt/prod-params
branch
from
458829a
to
d0fcdc9
Compare
NovemberTang
force-pushed
the
nt/prod-params
branch
from
f854bf6
to
0ea89ae
Compare
| return [ | ||
| { | ||
| cta: `View all findings on Grafana`, | ||
| url: `https://metrics.gutools.co.uk/d/ddi3x35x70jy8d?var-account_name=${encodeURIComponent(aws_account_name)}`, |
There was a problem hiding this comment.
It might be nice to pass in the dashboard name as a param to make it easier to parse as a human
There was a problem hiding this comment.
I'm not sure I understand what you mean by dashboard name? Or what would be easier to parse?
There was a problem hiding this comment.
I meant this bit: ddi3x35x70jy8d - maybe we could have a var called fsbpCompliance or somesuch in its place (since it's already a template string) - just to make it easier to see where it goes at a glance? Not that important though!
What does this change?
This PR is probably a bit easier to understand commit by commit.
How has it been verified?